pfree char* returned by TextDatumGetCString in is_pgtle_defined_c_func. #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although this is unlikely to cause a memory leak, still be consevative and free the memory.
formalLogicGirl
approved these changes
Jul 24, 2023
|
Was this the only place or was there a second call site? Will merge after checks complete |
I believe this is the only place we need this. There are a few TextDatumGetCString calls in datatype.c file, but they are not called in a loop, I don't think that's an issue at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pfree char* returned by TextDatumGetCString in is_pgtle_defined_c_func.
Although this is unlikely to cause a memory leak (memory context will take care of releasing it), still be consevative and free the memory.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.